Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #11514: add test case for base cell editor #13075

Merged
merged 1 commit into from
May 21, 2023
Merged

Issue #11514: add test case for base cell editor #13075

merged 1 commit into from
May 21, 2023

Conversation

heyannely
Copy link
Contributor

Solves issue #11514 Improve code coverage for GUI classes - BaseCellEditor

  • Added test file and new test cases for BaseCellEditor
  • Improved method coverage by 44% and line coverage by 69%
  • Built successfully with mvn clean verify

romani
romani requested changes May 21, 2023
View reviewed changes
Copy link
Member

@romani romani left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update coverage in pom.xml file , there is special block for this class.

items:

src/test/java/com/puppycrawl/tools/checkstyle/gui/BaseCellEditorTest.java Outdated Show resolved Hide resolved
@heyannely heyannely requested a review from romani May 21, 2023 07:20
@heyannely
Copy link
Contributor Author

@romani thanks for looking into it and have updated the pom.xml and variable name

romani
romani requested changes May 21, 2023
View reviewed changes
Copy link
Member

@romani romani left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please reply "done" to each review item, and I will resolve review item.

items:

src/test/java/com/puppycrawl/tools/checkstyle/gui/BaseCellEditorTest.java Outdated Show resolved Hide resolved
src/test/java/com/puppycrawl/tools/checkstyle/gui/BaseCellEditorTest.java Outdated Show resolved Hide resolved
romani
romani requested changes May 21, 2023
View reviewed changes
Copy link
Member

@romani romani left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied by comment "done" to each review item as you finish it.

Squash all commits in one, always keep single commit

Items

romani
romani approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge if CI is all green

@romani romani merged commit 2f55e67 into checkstyle:master May 21, 2023
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heyannely @romani