Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supplemental: enforce coverage ratio for gui tests to the current values #11514 #11520

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

pbludov
Copy link
Member

@pbludov pbludov commented Apr 6, 2022

supplemental PR for #11514

Coverage percentage should be explicitly specified in the pom.xml file to prevent coverage decrease.

@pbludov pbludov force-pushed the issue-11514-fix-current-coverage branch from 1150652 to e76b02c Compare April 6, 2022 20:45
@pbludov pbludov changed the title supplemental: enforce coverage ratio for gui tests to the current value supplemental: enforce coverage ratio for gui tests to the current values #11514 Apr 6, 2022
pom.xml Show resolved Hide resolved
@nrmancuso nrmancuso assigned rnveach and unassigned nrmancuso Apr 7, 2022
Copy link
Member

@rnveach rnveach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why we are removing the stars. Even if there are no subclasses, for them, they can remain until the entire exclude is removed.

@rnveach rnveach assigned romani and unassigned rnveach Apr 7, 2022
@romani
Copy link
Member

romani commented Apr 7, 2022

If subclasses appears, jacoco will fail as far as I remember

@romani romani merged commit c485257 into checkstyle:master Apr 7, 2022
@pbludov pbludov deleted the issue-11514-fix-current-coverage branch April 8, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants