Update to typescript-eslint v6 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cannot be published until these issues are resolved: |
|
Beta Published - Install Command: |
ramaghanta
approved these changes
Jul 28, 2023
| // eslint-disable-next-line unicorn/prefer-module | ||
| module.exports = { | ||
| parser: '@typescript-eslint/parser', | ||
| plugins: ['@checkdigit', '@typescript-eslint', 'sonarjs', 'import', 'no-only-tests', 'no-secrets', 'deprecate'], | ||
| plugins: ['@checkdigit', '@typescript-eslint', 'sonarjs', 'import', 'no-only-tests', 'no-secrets', 'n'], |
There was a problem hiding this comment.
until I saw the node specific rules down below, I thought this n was a mistake
| "@types/jest": "^29.5.2", | ||
| "jest": "^29.6.0", | ||
| "@types/jest": "^29.5.3", | ||
| "fclone": "^1.0.11", |
There was a problem hiding this comment.
another one. didn't realize why you were not using structuredClone() until I saw the usage of fclone
|
✅ PR review status - All reviews completed and approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117
Fixes #112