fix(stdin): trim space instead of \n #761
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we were trimming an ending \n, but it would then break a \r\n sequence, causing misrenders. this fixes it closes #682 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
ccoVeille
reviewed
Dec 10, 2024
| @@ -30,7 +30,7 @@ func Read() (string, error) { | |||
| } | |||
| } | |||
|
|
|||
| return strings.TrimSuffix(b.String(), "\n"), nil | |||
| return strings.TrimSpace(b.String()), nil | |||
There was a problem hiding this comment.
So you are also trimming on the left.
Please confirm if it intended and OK
There was a problem hiding this comment.
Good point. If it matters at all, assuming we'd want strings.TrimRight() to match strings.TrimSuffix.
There was a problem hiding this comment.
Thought about that, I'm not sure why we were trimming the eof \n... in any case, it's probably fine 🤔
| @@ -30,7 +30,7 @@ func Read() (string, error) { | |||
| } | |||
| } | |||
|
|
|||
| return strings.TrimSuffix(b.String(), "\n"), nil | |||
| return strings.TrimSpace(b.String()), nil | |||
There was a problem hiding this comment.
Would this trim \r\n suffixes?
meowgorithm
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were trimming an ending \n, but it would then break a \r\n sequence, causing misrenders.
this fixes it
closes #682