Implement S609, linux_commands_wildcard_injection #4504

scop · 2023-05-18T19:24:29Z

No description provided.

crates/ruff/src/checkers/ast/mod.rs

github-actions · 2023-05-18T20:13:41Z

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.01     16.6±0.20ms     2.5 MB/sec    1.00     16.4±0.14ms     2.5 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.0±0.04ms     4.1 MB/sec    1.01      4.1±0.09ms     4.1 MB/sec
linter/all-rules/numpy/globals.py          1.00    503.9±4.68µs     5.9 MB/sec    1.00    504.4±3.41µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.02      7.1±0.03ms     3.6 MB/sec    1.00      6.9±0.05ms     3.7 MB/sec
linter/default-rules/large/dataset.py      1.00      8.1±0.03ms     5.0 MB/sec    1.00      8.1±0.07ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01  1790.9±10.85µs     9.3 MB/sec    1.00  1780.2±20.52µs     9.4 MB/sec
linter/default-rules/numpy/globals.py      1.00    200.0±3.66µs    14.8 MB/sec    1.02    204.4±2.28µs    14.4 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.7±0.04ms     7.0 MB/sec    1.01      3.7±0.02ms     6.9 MB/sec
parser/large/dataset.py                    1.00      6.1±0.05ms     6.6 MB/sec    1.02      6.3±0.06ms     6.5 MB/sec
parser/numpy/ctypeslib.py                  1.00  1197.8±10.63µs    13.9 MB/sec    1.02  1226.4±11.02µs    13.6 MB/sec
parser/numpy/globals.py                    1.00    124.8±2.43µs    23.7 MB/sec    1.04    129.8±0.26µs    22.7 MB/sec
parser/pydantic/types.py                   1.00      2.6±0.02ms     9.7 MB/sec    1.01      2.7±0.03ms     9.6 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.02     22.4±0.71ms  1863.8 KB/sec    1.00     21.9±0.59ms  1905.5 KB/sec
linter/all-rules/numpy/ctypeslib.py        1.02      5.5±0.19ms     3.0 MB/sec    1.00      5.4±0.19ms     3.1 MB/sec
linter/all-rules/numpy/globals.py          1.01   640.7±25.68µs     4.6 MB/sec    1.00   636.3±23.82µs     4.6 MB/sec
linter/all-rules/pydantic/types.py         1.02      9.4±0.34ms     2.7 MB/sec    1.00      9.2±0.37ms     2.8 MB/sec
linter/default-rules/large/dataset.py      1.01     10.9±0.28ms     3.7 MB/sec    1.00     10.8±0.34ms     3.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.3±0.08ms     7.2 MB/sec    1.00      2.3±0.11ms     7.2 MB/sec
linter/default-rules/numpy/globals.py      1.00   262.5±16.26µs    11.2 MB/sec    1.00   263.0±18.49µs    11.2 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.9±0.16ms     5.2 MB/sec    1.01      4.9±0.99ms     5.2 MB/sec
parser/large/dataset.py                    1.00      8.1±0.21ms     5.0 MB/sec    1.00      8.1±0.18ms     5.1 MB/sec
parser/numpy/ctypeslib.py                  1.00  1524.8±51.98µs    10.9 MB/sec    1.00  1519.1±139.60µs    11.0 MB/sec
parser/numpy/globals.py                    1.00    154.0±7.26µs    19.2 MB/sec    1.00    153.8±7.34µs    19.2 MB/sec
parser/pydantic/types.py                   1.02      3.5±0.19ms     7.3 MB/sec    1.00      3.4±0.12ms     7.4 MB/sec

crates/ruff/src/rules/flake8_bandit/rules/shell_injection.rs

MichaReiser · 2023-05-19T07:22:47Z

.../ruff/src/rules/flake8_bandit/snapshots/ruff__rules__flake8_bandit__tests__S609_S609.py.snap

+---
+source: crates/ruff/src/rules/flake8_bandit/mod.rs
+---
+S609.py:4:1: S609 Possible wildcard injection in call


I assume you copied this message from the upstream plugin? I struggle to understand the message. Which part of my code is triggering the wildcard injection? Unfortunately, I also don't know how to improve the message much without our Diagnostic's supporting an advice that is shown to explain the rule in more detail.

Yes, the message comes from Bandit: https://bandit.readthedocs.io/en/latest/plugins/b609_linux_commands_wildcard_injection.html

I did not bother to include the called function name in the message, but I don't think doing so would make it any clearer. Anyway I don't think it's a particularly good one either. Something like "Potentially dangerous use of wildcard in shell call" could be better, but then again I'm not sure how close to upstream Ruff wants to stick.

Co-authored-by: Micha Reiser <micha@reiser.io>

scop · 2023-05-25T08:19:54Z

Resolved conflicts.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `^0.0.270` -> `^0.0.271` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.271/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.271/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.271/compatibility-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.271/confidence-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.271`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271)  #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4742 - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@jlaneve](https://togithub.com/jlaneve) in [astral-sh/ruff#4687 - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4504 - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4882 - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4681 - \[`flake8-future-annotations`] Implement `FA102` by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4702 - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4756 - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4764 - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4695 - \[`flake8-pyi`] Add autofix for PYI010 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4634 - \[`flake8-pyi`] Implement PYI029 by [@density](https://togithub.com/density) in [astral-sh/ruff#4851 - \[`flake8-pyi`] Implement PYI035 by [@density](https://togithub.com/density) in [astral-sh/ruff#4820 - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4645 - \[`flake8-pyi`] Implement PYI053 by [@density](https://togithub.com/density) in [astral-sh/ruff#4770 - \[`flake8-pyi`] Implement PYI054 by [@density](https://togithub.com/density) in [astral-sh/ruff#4775 - \[`flake8-pyi`] Implement `PYI025` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4791 - \[`flake8-pyi`] Implement `PYI045` by [@density](https://togithub.com/density) in [astral-sh/ruff#4700 - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#4706 - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4792 - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#4668 - \[`pylint`] implement E307 for pylint invalid str return type by [@Ryang20718](https://togithub.com/Ryang20718) in [astral-sh/ruff#4854 - \[`ruff`] Lint pyproject.toml by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4496 - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4797 ##### Settings - Add `pyflakes.extend-generics` setting by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4677 ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4683 - Handle dotted alias imports to check for implicit imports by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4685 - Flag empty strings in flake8-errmsg rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4745 - Exclude function definition from too-many-statements rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4794 - Preserve quotes in F523 fixer by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4836 - Fix round-tripping of nested functions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4875 - Avoid early-exit in explicit-f-string-type-conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4886 - Avoid no-op fix for nested with expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4906 - Fix UP036 auto-fix error by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4679 - Use class name as range for `B024` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4647 - Change TODO directive detection to work with multiple pound signs on the same line by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4558 - Allow more immutable funcs for RUF009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4660 - Avoid using typing-imported symbols for runtime edits by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4649 - Fix `async for` formatting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4675 - Ignore **setattr** in FBT003 by [@alexfikl](https://togithub.com/alexfikl) in [astral-sh/ruff#4752 - Include ImportError in non-fixable try-catch imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4793 - Avoid extra newline between diagnostics in grouped mode by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4776 - Avoid enforcing native-literals rule within nested f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4488 - Respect mixed variable assignment in RET504 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4835 - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4834 - Add some exceptions for FBT003 ([#3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [astral-sh/ruff#4867 - Avoid running RUF100 rules when code contains syntax errors by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4869 - Avoid index-out-of-bands panic for positional placeholders by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4872 - Remove destructive fixes for F523 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4883 - Respect shadowed exports in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4885 - Track symbol deletions separately from bindings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4888 - Change fixable_set to include RuleSelector::All/Nursery by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4852 #### New Contributors - [@bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [astral-sh/ruff#4644 - [@jlaneve](https://togithub.com/jlaneve) made their first contribution in [astral-sh/ruff#4690 - [@suharnikov](https://togithub.com/suharnikov) made their first contribution in [astral-sh/ruff#4678 - [@alexfikl](https://togithub.com/alexfikl) made their first contribution in [astral-sh/ruff#4752 - [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [astral-sh/ruff#4867 - [@Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [astral-sh/ruff#4854 - [@addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [astral-sh/ruff#4893 **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).  Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `0.0.270` -> `0.0.272` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/compatibility-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/confidence-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.272`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.272) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.271...v0.0.272)  #### What's Changed ##### Breaking Changes - Move flake8-fixme rules to FIX prefix by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4917 ##### Rules - \[`flake8-pyi`] Implement PYI050 by [@density](https://togithub.com/density) in [astral-sh/ruff#4884 ##### Bug Fixes - Avoid attributing runtime references to module-level imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4942 - Skip class scopes when resolving nonlocal references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4943 - Apply `dict.get` fix before ternary rewrite by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4944 - Handle implicit string concatenations in conversion-flag rewrites by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4947 - Make `C413` fix as suggested for `reversed` call by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4891 - ignore if using infinite iterators in `B905` by [@kyoto7250](https://togithub.com/kyoto7250) in [astral-sh/ruff#4914 **Full Changelog**: astral-sh/ruff@v0.0.271...v0.0.272 ### [`v0.0.271`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271)  #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4742 - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@jlaneve](https://togithub.com/jlaneve) in [astral-sh/ruff#4687 - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4504 - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4882 - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4681 - \[`flake8-future-annotations`] Implement `FA102` by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4702 - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4756 - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4764 - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4695 - \[`flake8-pyi`] Add autofix for PYI010 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4634 - \[`flake8-pyi`] Implement PYI029 by [@density](https://togithub.com/density) in [astral-sh/ruff#4851 - \[`flake8-pyi`] Implement PYI035 by [@density](https://togithub.com/density) in [astral-sh/ruff#4820 - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4645 - \[`flake8-pyi`] Implement PYI053 by [@density](https://togithub.com/density) in [astral-sh/ruff#4770 - \[`flake8-pyi`] Implement PYI054 by [@density](https://togithub.com/density) in [astral-sh/ruff#4775 - \[`flake8-pyi`] Implement `PYI025` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4791 - \[`flake8-pyi`] Implement `PYI045` by [@density](https://togithub.com/density) in [astral-sh/ruff#4700 - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#4706 - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4792 - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#4668 - \[`pylint`] implement E307 for pylint invalid str return type by [@Ryang20718](https://togithub.com/Ryang20718) in [astral-sh/ruff#4854 - \[`ruff`] Lint pyproject.toml by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4496 - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4797 ##### Settings - Add `pyflakes.extend-generics` setting by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4677 ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4683 - Handle dotted alias imports to check for implicit imports by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4685 - Flag empty strings in flake8-errmsg rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4745 - Exclude function definition from too-many-statements rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4794 - Preserve quotes in F523 fixer by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4836 - Fix round-tripping of nested functions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4875 - Avoid early-exit in explicit-f-string-type-conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4886 - Avoid no-op fix for nested with expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4906 - Fix UP036 auto-fix error by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4679 - Use class name as range for `B024` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4647 - Change TODO directive detection to work with multiple pound signs on the same line by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4558 - Allow more immutable funcs for RUF009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4660 - Avoid using typing-imported symbols for runtime edits by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4649 - Fix `async for` formatting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4675 - Ignore **setattr** in FBT003 by [@alexfikl](https://togithub.com/alexfikl) in [astral-sh/ruff#4752 - Include ImportError in non-fixable try-catch imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4793 - Avoid extra newline between diagnostics in grouped mode by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4776 - Avoid enforcing native-literals rule within nested f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4488 - Respect mixed variable assignment in RET504 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4835 - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4834 - Add some exceptions for FBT003 ([#3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [astral-sh/ruff#4867 - Avoid running RUF100 rules when code contains syntax errors by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4869 - Avoid index-out-of-bands panic for positional placeholders by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4872 - Remove destructive fixes for F523 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4883 - Respect shadowed exports in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4885 - Track symbol deletions separately from bindings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4888 - Change fixable_set to include RuleSelector::All/Nursery by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4852 #### New Contributors - [@bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [astral-sh/ruff#4644 - [@jlaneve](https://togithub.com/jlaneve) made their first contribution in [astral-sh/ruff#4690 - [@suharnikov](https://togithub.com/suharnikov) made their first contribution in [astral-sh/ruff#4678 - [@alexfikl](https://togithub.com/alexfikl) made their first contribution in [astral-sh/ruff#4752 - [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [astral-sh/ruff#4867 - [@Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [astral-sh/ruff#4854 - [@addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [astral-sh/ruff#4893 **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/jankatins/pr-workflow-example).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.270` -> `==0.0.272` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/compatibility-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/confidence-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.272`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.272) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.271...v0.0.272)  #### What's Changed ##### Breaking Changes - Move flake8-fixme rules to FIX prefix by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4917 ##### Rules - \[`flake8-pyi`] Implement PYI050 by [@density](https://togithub.com/density) in [astral-sh/ruff#4884 ##### Bug Fixes - Avoid attributing runtime references to module-level imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4942 - Skip class scopes when resolving nonlocal references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4943 - Apply `dict.get` fix before ternary rewrite by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4944 - Handle implicit string concatenations in conversion-flag rewrites by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4947 - Make `C413` fix as suggested for `reversed` call by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4891 - ignore if using infinite iterators in `B905` by [@kyoto7250](https://togithub.com/kyoto7250) in [astral-sh/ruff#4914 **Full Changelog**: astral-sh/ruff@v0.0.271...v0.0.272 ### [`v0.0.271`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271)  #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4742 - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@jlaneve](https://togithub.com/jlaneve) in [astral-sh/ruff#4687 - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4504 - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4882 - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4681 - \[`flake8-future-annotations`] Implement `FA102` by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4702 - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4756 - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4764 - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4695 - \[`flake8-pyi`] Add autofix for PYI010 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4634 - \[`flake8-pyi`] Implement PYI029 by [@density](https://togithub.com/density) in [astral-sh/ruff#4851 - \[`flake8-pyi`] Implement PYI035 by [@density](https://togithub.com/density) in [astral-sh/ruff#4820 - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4645 - \[`flake8-pyi`] Implement PYI053 by [@density](https://togithub.com/density) in [astral-sh/ruff#4770 - \[`flake8-pyi`] Implement PYI054 by [@density](https://togithub.com/density) in [astral-sh/ruff#4775 - \[`flake8-pyi`] Implement `PYI025` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4791 - \[`flake8-pyi`] Implement `PYI045` by [@density](https://togithub.com/density) in [astral-sh/ruff#4700 - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#4706 - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4792 - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#4668 - \[`pylint`] implement E307 for pylint invalid str return type by [@Ryang20718](https://togithub.com/Ryang20718) in [astral-sh/ruff#4854 - \[`ruff`] Lint pyproject.toml by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4496 - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4797 ##### Settings - Add `pyflakes.extend-generics` setting by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4677 ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4683 - Handle dotted alias imports to check for implicit imports by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4685 - Flag empty strings in flake8-errmsg rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4745 - Exclude function definition from too-many-statements rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4794 - Preserve quotes in F523 fixer by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4836 - Fix round-tripping of nested functions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4875 - Avoid early-exit in explicit-f-string-type-conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4886 - Avoid no-op fix for nested with expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4906 - Fix UP036 auto-fix error by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4679 - Use class name as range for `B024` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4647 - Change TODO directive detection to work with multiple pound signs on the same line by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4558 - Allow more immutable funcs for RUF009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4660 - Avoid using typing-imported symbols for runtime edits by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4649 - Fix `async for` formatting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4675 - Ignore **setattr** in FBT003 by [@alexfikl](https://togithub.com/alexfikl) in [astral-sh/ruff#4752 - Include ImportError in non-fixable try-catch imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4793 - Avoid extra newline between diagnostics in grouped mode by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4776 - Avoid enforcing native-literals rule within nested f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4488 - Respect mixed variable assignment in RET504 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4835 - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4834 - Add some exceptions for FBT003 ([#3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [astral-sh/ruff#4867 - Avoid running RUF100 rules when code contains syntax errors by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4869 - Avoid index-out-of-bands panic for positional placeholders by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4872 - Remove destructive fixes for F523 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4883 - Respect shadowed exports in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4885 - Track symbol deletions separately from bindings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4888 - Change fixable_set to include RuleSelector::All/Nursery by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4852 #### New Contributors - [@bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [astral-sh/ruff#4644 - [@jlaneve](https://togithub.com/jlaneve) made their first contribution in [astral-sh/ruff#4690 - [@suharnikov](https://togithub.com/suharnikov) made their first contribution in [astral-sh/ruff#4678 - [@alexfikl](https://togithub.com/alexfikl) made their first contribution in [astral-sh/ruff#4752 - [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [astral-sh/ruff#4867 - [@Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [astral-sh/ruff#4854 - [@addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [astral-sh/ruff#4893 **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.270` -> `==0.0.272` | [![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/compatibility-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.272/confidence-slim/0.0.270)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.272`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.272) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.271...v0.0.272)  #### What's Changed ##### Breaking Changes - Move flake8-fixme rules to FIX prefix by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4917 ##### Rules - \[`flake8-pyi`] Implement PYI050 by [@density](https://togithub.com/density) in [astral-sh/ruff#4884 ##### Bug Fixes - Avoid attributing runtime references to module-level imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4942 - Skip class scopes when resolving nonlocal references by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4943 - Apply `dict.get` fix before ternary rewrite by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4944 - Handle implicit string concatenations in conversion-flag rewrites by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4947 - Make `C413` fix as suggested for `reversed` call by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4891 - ignore if using infinite iterators in `B905` by [@kyoto7250](https://togithub.com/kyoto7250) in [astral-sh/ruff#4914 **Full Changelog**: astral-sh/ruff@v0.0.271...v0.0.272 ### [`v0.0.271`](https://togithub.com/astral-sh/ruff/releases/tag/v0.0.271) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.270...v0.0.271)  #### What's Changed ##### Rules - Add autofix for flake8-type-checking by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4742 - \[`airflow`] Add AIR001: task variable name should be same as task_id arg by [@jlaneve](https://togithub.com/jlaneve) in [astral-sh/ruff#4687 - \[`flake8-bandit`] Implement S609, linux_commands_wildcard_injection by [@scop](https://togithub.com/scop) in [astral-sh/ruff#4504 - \[`flake8-bugbear`] Move duplicate-value rule to flake8-bugbear by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4882 - \[`flake8-fixme`] Implement `flake8_fixme` and refactor `TodoDirective` by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4681 - \[`flake8-future-annotations`] Implement `FA102` by [@akx](https://togithub.com/akx) in [astral-sh/ruff#4702 - \[`flake8-pyi`] Add PYI024 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4756 - \[`flake8-pyi`] Add PYI034 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4764 - \[`flake8-pyi`] Add `PYI032` rule with autofix by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4695 - \[`flake8-pyi`] Add autofix for PYI010 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4634 - \[`flake8-pyi`] Implement PYI029 by [@density](https://togithub.com/density) in [astral-sh/ruff#4851 - \[`flake8-pyi`] Implement PYI035 by [@density](https://togithub.com/density) in [astral-sh/ruff#4820 - \[`flake8-pyi`] Implement PYI048 for `flake8-pyi` plugin by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4645 - \[`flake8-pyi`] Implement PYI053 by [@density](https://togithub.com/density) in [astral-sh/ruff#4770 - \[`flake8-pyi`] Implement PYI054 by [@density](https://togithub.com/density) in [astral-sh/ruff#4775 - \[`flake8-pyi`] Implement `PYI025` by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4791 - \[`flake8-pyi`] Implement `PYI045` by [@density](https://togithub.com/density) in [astral-sh/ruff#4700 - \[`pylint`] Add Pylint rule `C0208` (`use-sequence-for-iteration`) as `PLC0208` (`iteration-over-set`) by [@tjkuson](https://togithub.com/tjkuson) in [astral-sh/ruff#4706 - \[`pylint`] Add autofix for `PLR1701` (repeated-isinstance-calls) by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4792 - \[`pylint`] Implement Pylint's `yield-inside-async-function` rule (`PLE1700`) by [@chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#4668 - \[`pylint`] implement E307 for pylint invalid str return type by [@Ryang20718](https://togithub.com/Ryang20718) in [astral-sh/ruff#4854 - \[`ruff`] Lint pyproject.toml by [@konstin](https://togithub.com/konstin) in [astral-sh/ruff#4496 - \[`tryceratops`] Ignore error calls with `exc_info` in TRY400 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4797 ##### Settings - Add `pyflakes.extend-generics` setting by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4677 ##### Bug Fixes - Fix PLW3301 false positive single argument nested min/max by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4683 - Handle dotted alias imports to check for implicit imports by [@dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#4685 - Flag empty strings in flake8-errmsg rules by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4745 - Exclude function definition from too-many-statements rule by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4794 - Preserve quotes in F523 fixer by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4836 - Fix round-tripping of nested functions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4875 - Avoid early-exit in explicit-f-string-type-conversion by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4886 - Avoid no-op fix for nested with expressions by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4906 - Fix UP036 auto-fix error by [@JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4679 - Use class name as range for `B024` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4647 - Change TODO directive detection to work with multiple pound signs on the same line by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4558 - Allow more immutable funcs for RUF009 by [@qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4660 - Avoid using typing-imported symbols for runtime edits by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4649 - Fix `async for` formatting by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4675 - Ignore **setattr** in FBT003 by [@alexfikl](https://togithub.com/alexfikl) in [astral-sh/ruff#4752 - Include ImportError in non-fixable try-catch imports by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4793 - Avoid extra newline between diagnostics in grouped mode by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4776 - Avoid enforcing native-literals rule within nested f-strings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4488 - Respect mixed variable assignment in RET504 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4835 - Make FLY002 autofix into a constant string instead of an f-string if all `join()` arguments are strings by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4834 - Add some exceptions for FBT003 ([#3247](https://togithub.com/charliermarsh/ruff/issues/3247)) by [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) in [astral-sh/ruff#4867 - Avoid running RUF100 rules when code contains syntax errors by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4869 - Avoid index-out-of-bands panic for positional placeholders by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4872 - Remove destructive fixes for F523 by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4883 - Respect shadowed exports in `__all__` by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4885 - Track symbol deletions separately from bindings by [@charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4888 - Change fixable_set to include RuleSelector::All/Nursery by [@evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#4852 #### New Contributors - [@bersbersbers](https://togithub.com/bersbersbers) made their first contribution in [astral-sh/ruff#4644 - [@jlaneve](https://togithub.com/jlaneve) made their first contribution in [astral-sh/ruff#4690 - [@suharnikov](https://togithub.com/suharnikov) made their first contribution in [astral-sh/ruff#4678 - [@alexfikl](https://togithub.com/alexfikl) made their first contribution in [astral-sh/ruff#4752 - [@allisonkarlitskaya](https://togithub.com/allisonkarlitskaya) made their first contribution in [astral-sh/ruff#4867 - [@Ryang20718](https://togithub.com/Ryang20718) made their first contribution in [astral-sh/ruff#4854 - [@addisoncrump](https://togithub.com/addisoncrump) made their first contribution in [astral-sh/ruff#4893 **Full Changelog**: astral-sh/ruff@v0.0.270...v0.0.271 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

scop commented May 18, 2023

View reviewed changes

crates/ruff/src/checkers/ast/mod.rs Show resolved Hide resolved

scop mentioned this pull request May 18, 2023

Replace bandit with ruff home-assistant/core#93200

Merged

23 tasks

scop force-pushed the feat/bandit-wildcard-injection branch from 46936b3 to eb993ea Compare May 18, 2023 19:38

Implement S609, linux_commands_wildcard_injection

0a00bdc

scop force-pushed the feat/bandit-wildcard-injection branch from eb993ea to 0a00bdc Compare May 18, 2023 20:29

MichaReiser reviewed May 19, 2023

View reviewed changes

scop mentioned this pull request May 19, 2023

Implement flake8-bandit #1646

Open

75 tasks

scop and others added 2 commits May 19, 2023 11:32

Apply suggestions from code review

3ad2e6b

Co-authored-by: Micha Reiser <micha@reiser.io>

Merge branch 'main' into feat/bandit-wildcard-injection

f46d273

charliermarsh added 4 commits June 2, 2023 11:47

Merge branch 'main' into feat/bandit-wildcard-injection

bfe161a

Remove regex

1ab2ee6

Merge branch 'main' into feat/bandit-wildcard-injection

b482626

Remove mutable var

fcec0b2

charliermarsh added the rule Implementing or modifying a lint rule label Jun 2, 2023

charliermarsh enabled auto-merge (squash) June 2, 2023 18:11

charliermarsh merged commit 0a5dfcb into astral-sh:main Jun 2, 2023
14 checks passed

scop deleted the feat/bandit-wildcard-injection branch June 2, 2023 18:26

chenrui333 mentioned this pull request Jun 6, 2023

ruff 0.0.272 Homebrew/homebrew-core#133013

Merged

konstin pushed a commit that referenced this pull request Jun 13, 2023

Implement S609, linux_commands_wildcard_injection (#4504)

20cab9e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement S609, linux_commands_wildcard_injection #4504

Implement S609, linux_commands_wildcard_injection #4504

scop commented May 18, 2023

github-actions bot commented May 18, 2023 •

edited

MichaReiser May 19, 2023

scop May 19, 2023

scop commented May 25, 2023

Implement S609, linux_commands_wildcard_injection #4504

Implement S609, linux_commands_wildcard_injection #4504

Conversation

scop commented May 18, 2023

github-actions bot commented May 18, 2023 • edited

PR Check Results

Ecosystem

Benchmark

Linux

Windows

MichaReiser May 19, 2023

Choose a reason for hiding this comment

scop May 19, 2023

Choose a reason for hiding this comment

scop commented May 25, 2023

github-actions bot commented May 18, 2023 •

edited