Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default node version from actions/setup-node #233

Closed
wants to merge 1 commit into from
Closed

Use default node version from actions/setup-node #233

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 17, 2022

Follow-up to #216

The actions/setup-node@v3 uses node16 by default.
The changesets/action can delegate selecting node version, and simplify configuration.

https://github.com/actions/setup-node/blob/6bc15ab23c9584a6fe2fdf1ae07fd5fb409d1dbc/action.yml#L36

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2022

⚠️ No Changeset found

Latest commit: 0eab77f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -1,7 +1,6 @@
name: Changesets
description: A GitHub action to automate releases with Changesets
runs:
using: "node16"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what exact impact that would have on consumers of this action though? isn't it recommended to use an explicit version here?

@Andarist
Copy link
Member

What you have linked to is pointing to the version used to execute actions/setup-node itself and not to what version of node does it setup for other things executed by the runner in steps following the setup action.

In their README we can find this:

The node-version input is optional. If not supplied, the node version from PATH will be used. However, it is recommended to always specify Node.js version and don't rely on the system one.

@trivikr trivikr closed this Nov 19, 2022
@trivikr trivikr deleted the use-default-node branch November 19, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants