Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve rtl support for breadcrumb #9616

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

mhsattarian
Copy link
Contributor

Closes #9615

📝 Description

Hides list marker and Rotates separator in rtl parent/page.

⛳️ Current behavior (updates)

currently the chevron is in the wrong direction (facing right instead of left) and list marker from user set list-style property can be visible inside breadcrumb's UI.

🚀 New behavior

Now, chevron is rotated to face the correct direction for RTL breadcrumb and using listStyle:none property no marker is visilble for Items.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

hide list marker and rotate separator for rtl in rtl parent/page
Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: 9732b67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@chakra-ui/react Patch
@chakra-ui/cli Patch
@chakra-ui/panda-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
chakra-ui-storybook ✅ Ready (Inspect) Visit Preview Feb 5, 2025 1:02pm
chakra-v3-docs ✅ Ready (Inspect) Visit Preview Feb 5, 2025 1:02pm

@segunadebayo segunadebayo changed the title improve rtl support for breadcrumb.ts fix: improve rtl support for breadcrumb Feb 5, 2025
@segunadebayo segunadebayo merged commit 54a73a7 into chakra-ui:main Feb 5, 2025
4 of 7 checks passed
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumb separator has issues in rtl pages
2 participants