New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pathval #1527
Update pathval #1527
Conversation
Good catch! One step closer to pure esm 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have to change from require
to import
here?
Line 11 in 1a8247f
var pathval = require('pathval'); |
Nope, the file has already got |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed that this PR was targeting a non-main branch as it wasn't mentioned anywhere and I didn't think of looking at the target branch as its so rare for projects to merge towards a non-main branch.
I would suggest creating a milestone and/or tracking issue that can convey this context to new contributors.
@keithamus; I don't have merge rights, so I can't land this myself. It also might be good to remove node12 and node14 as required builds in the repo settings, since they are never going to be reported. |
I've given you merge rights, so feel free to merge 👍 |
Since it's now an ES Module! :)