Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pathval #1527

Merged
merged 1 commit into from Jul 26, 2023
Merged

Update pathval #1527

merged 1 commit into from Jul 26, 2023

Conversation

koddsson
Copy link
Member

Since it's now an ES Module! :)

@koddsson koddsson requested a review from a team as a code owner July 21, 2023 20:05
@43081j
Copy link
Contributor

43081j commented Jul 21, 2023

Good catch! One step closer to pure esm 👀

Copy link

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have to change from require to import here?

var pathval = require('pathval');

@koddsson
Copy link
Member Author

Would have to change from require to import here?

Nope, the file has already got import calls in the 5.x.x branch which this PR is targeting.

Copy link

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that this PR was targeting a non-main branch as it wasn't mentioned anywhere and I didn't think of looking at the target branch as its so rare for projects to merge towards a non-main branch.

I would suggest creating a milestone and/or tracking issue that can convey this context to new contributors.

@koddsson
Copy link
Member Author

@keithamus; I don't have merge rights, so I can't land this myself.

It also might be good to remove node12 and node14 as required builds in the repo settings, since they are never going to be reported.

@keithamus
Copy link
Member

I've given you merge rights, so feel free to merge 👍

@koddsson koddsson merged commit ca99d66 into chaijs:5.x.x Jul 26, 2023
3 checks passed
@koddsson koddsson deleted the update-pathval branch July 26, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants