New sinks for TaintedCallable vimeo#10117

cgocast · Aug 26, 2023 · ec717f3 · ec717f3
1 parent 4e177bf
commit ec717f3
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/stubs/Reflection.phpstub b/stubs/Reflection.phpstub
@@ -14,6 +14,7 @@ class ReflectionClass implements Reflector {
 
     /**
      * @param T|class-string<T>|interface-string<T>|trait-string|enum-string<T> $argument
+     * @psalm-taint-sink callable $argument
      */
     public function __construct($argument) {}
 
@@ -58,6 +59,11 @@ class ReflectionClass implements Reflector {
 
 class ReflectionFunction implements Reflector
 {
+    /**
+     * @psalm-taint-sink callable $function
+     */
+    public function __construct(callable $function) {}
+
     /**
      * @since 8.0
      * @template TClass as object

diff --git a/tests/TaintTest.php b/tests/TaintTest.php
@@ -2373,6 +2373,20 @@ public static function getPrevious(string $s): string {
                     new $a($b);',
                 'error_message' => 'TaintedCallable',
             ],
+            'taintedReflectionClass' => [
+                'code' => '<?php
+                    $name = $_GET["name"];
+                    $reflector = new ReflectionClass($name);
+                    $reflector->newInstance();',
+                'error_message' => 'TaintedCallable',
+            ],
+            'taintedReflectionFunction' => [
+                'code' => '<?php
+                    $name = $_GET["name"];
+                    $function = new ReflectionFunction($name);
+                    $function->invoke();',
+                'error_message' => 'TaintedCallable',
+            ],
         ];
     }