CFE-3785: Changed cfbs pretty command to always wrap non-empty top level collections #191
+146
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehermanse
changed the title
olehermanse
reviewed
May 2, 2024
cfbs/pretty.py
Outdated
Comment on lines
238
to
239
| if not lst and indent == 0: | ||
| return "[\n]" | ||
| elif not lst: | ||
| return "[]" |
There was a problem hiding this comment.
@mineralsfree @larsewi How about keeping it on one line if it's completely empty?
olehermanse
reviewed
May 2, 2024
cfbs/pretty.py
Outdated
Comment on lines
263
to
262
| if not dct and indent == 0: | ||
| return "{\n}" | ||
| elif not dct: | ||
| return "{}" |
There was a problem hiding this comment.
@larsewi @mineralsfree same here
olehermanse
approved these changes
May 2, 2024
There was a problem hiding this comment.
Looks good overall, left one suggestion / question.
A couple of notes:
I edited the PR title to be past tense and perhaps a bit easier to understand. In this repo (same in cf-remote) we release in GitHub, and PR titles get automatically added to changelogs (Changelog: None has no effect). Also, this change is user facing, so I think it makes sense to include in changelogs.
Ticket: CFE-3785 Changelog: None Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>
olehermanse
changed the title
olehermanse
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CFE-3785
Changelog: None
Signed-off-by: Mikita Pilinka mikita.pilinka@northern.tech