Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.14] Remove docker custom network hack which has been moved to the test runner #6940

Merged
merged 1 commit into from
Apr 22, 2024
Merged

[release-1.14] Remove docker custom network hack which has been moved to the test runner #6940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 0 additions & 20 deletions make/cluster.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,26 +126,6 @@ if [ -n "$show_image" ]; then
fi

setup_kind() {
# When running in our CI environment the Docker network's subnet choice will
# cause issues with routing, which can manifest in errors such as this one:
#
# dial tcp: lookup charts.jetstack.io on 10.8.240.10:53: read udp 10.8.0.2:54823->10.8.240.10:53: i/o timeout
#
# as seen in the build [1]. We create this custom network as a workaround
# until we have a way to properly patch this.
#
# [1]: https://prow.build-infra.jetstack.net/view/gs/jetstack-logs/pr-logs/pull/cert-manager_approver-policy/36/pull-cert-manager-approver-policy-smoke/1447565895923666944#1:build-log.txt%3A222
if printenv CI >/dev/null; then
if ! docker network inspect kind >/dev/null 2>&1; then
docker network create --driver=bridge --subnet=192.168.0.0/16 --gateway 192.168.0.1 kind
fi

# Wait for the network to be created so kind does not overwrite it.
while ! docker network inspect kind >/dev/null; do
sleep 100ms
done
fi

# (1) Does the kind cluster already exist?
if ! kind get clusters -q | grep -q "^$kind_cluster_name\$"; then
trace kind create cluster --config "make/config/kind/cluster.yaml" \
Expand Down