Remove docker custom network hack which has been moved to the test runner #6938
Conversation
…has been patched Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
cert-manager-prow
bot
added
kind/cleanup
|
/cherry-pick release-1.12 |
|
/cherry-pick release-1.13 |
|
@inteon: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@inteon: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.14 |
|
@inteon: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/approve |
cert-manager-prow
bot
added
the
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, ThatsMrTalbot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@inteon: new pull request created: #6939 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@inteon: new pull request created: #6940 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@inteon: new pull request created: #6941 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In cert-manager/testing#1011, the docker networking hack that was lives in cert-manager/cert-manager was added to the testing runner script.
However, I did not expect that this would cause the cert-manager tests to fail due to the hack in this repo conflicting with the fix in the runner script (see https://storage.googleapis.com/cert-manager-prow-artifacts/pr-logs/pull/batch/pull-cert-manager-master-e2e-v1-28/1782439419886702592/build-log.txt).
This PR removes the docker network hack from cert-manager/cert-manager since it is already present in the runner script and both hacks are not compatible.
Kind
/kind cleanup
Release Note