Limit DigitalOcean records for cleanup to TXT only

[SgtCoDFish]

There was a slack report that in cleanup, the digitalocean webhook would delete A records if the domain had a CNAME.

I’m using DNS01 validation (with DigitalOcean as the provider) for a domain which is CNAME’d. Every time there’s a challenge which succeeds, in the clean up process, the A record where the verification domain is pointing to gets deleted. This causes many sites to fall over.

I don't really have the bandwidth to dig too much into that right now, but it seems a pretty severe bug so it seems worth trying a fix.

This PR should ensure that only TXT records can be considered for deletion.

Kind

/kind bug

Release Note

DigitalOcean: Ensure that only TXT records are considered for deletion when cleaning up after an ACME challenge

[BobyMCbobs]

@SgtCoDFish, thank you for your help with this. To my short local testing, this fixes it.

1. challenge created
2. TXT record created
3. challenge succeeds
4. TXT record deleted and A record used in CNAME ref not deleted

[SgtCoDFish]

/cherry-pick release-1.12

(tagging for a backport since this is quite a nasty bug)

[jetstack-bot]

@SgtCoDFish: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

(tagging for a backport since this is quite a nasty bug)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[SgtCoDFish]

/cherry-pick release-1.13

(tagging for a backport since this is quite a nasty bug)

[jetstack-bot]

@SgtCoDFish: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

(tagging for a backport since this is quite a nasty bug)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[SgtCoDFish]

/cherry-pick release-1.14

(tagging for a backport since this is quite a nasty bug)

[jetstack-bot]

@SgtCoDFish: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

(tagging for a backport since this is quite a nasty bug)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ThatsMrTalbot]

Nice one line fix 👍
/lgtm
/approve

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ThatsMrTalbot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ThatsMrTalbot]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[SgtCoDFish]

/test pull-cert-manager-master-e2e-v1-28

Flake with pebble, unrelated to this PR

[jetstack-bot]

@SgtCoDFish: new pull request created: #6892

In response to this:

/cherry-pick release-1.13

(tagging for a backport since this is quite a nasty bug)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jetstack-bot]

@SgtCoDFish: new pull request created: #6893

In response to this:

/cherry-pick release-1.14

(tagging for a backport since this is quite a nasty bug)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jetstack-bot]

@SgtCoDFish: new pull request created: #6894

In response to this:

/cherry-pick release-1.12

(tagging for a backport since this is quite a nasty bug)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.