Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.13] fix go-restful dependency "do not use" version #6362

Closed
wants to merge 1 commit into from
Closed

[release-1.13] fix go-restful dependency "do not use" version #6362

wants to merge 1 commit into from

Conversation

inteon
Copy link
Member

@inteon inteon commented Sep 26, 2023 •
edited

Pull Request Motivation

In #6332, I upgraded the go-restful dependency, but missed that the version is labeled "do not use" in its CHANGES.md file (https://github.com/emicklei/go-restful/blob/v3/CHANGES.md#v3102---2023-03-09---do-not-use).

Kind

/kind cleanup

Release Note

Upgrade `github.com/emicklei/go-restful/v3` to `v3.11.0` because `v3.10.2` is labeled as "DO NOT USE".

@inteon
fix go-restful 'DO NOT USE' version
6765d76 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2023
@inteon inteon changed the base branch from master to release-1.13 September 26, 2023 08:07
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from inteon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added area/testing Issues relating to testing size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 26, 2023
@cert-manager cert-manager deleted a comment from jetstack-bot Sep 26, 2023
@cert-manager cert-manager deleted a comment from jetstack-bot Sep 26, 2023
@inteon inteon removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. area/testing Issues relating to testing needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 26, 2023
@cert-manager cert-manager deleted a comment from jetstack-bot Sep 26, 2023
@inteon
Copy link
Member Author

inteon commented Sep 26, 2023

closing in favor of #6368

@inteon inteon closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inteon @jetstack-bot