-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce config file for cainjector options #6345
Conversation
a8e924f
to
9784cd5
Compare
49a8728
to
79c6484
Compare
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
79c6484
to
919f809
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
This is so big that it's kinda hard to review. Part of that is our pattern of using k8s resources to define config rather than a much simpler format - that feels a bit like using a sledgehammer on a nail, but obviously it's the pattern we've established already so it makes sense to use it again here.
This is too big for me to be really confident about it, but I don't think that should be a blocker for us if tests pass, and I like the tests in cmd/cainjector/app/cainjector_test.go !
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Similar to #5337, but for the cainjector.
The approach and structure is identical to the existing setup for the controller and for the webhook.
Kind
/kind feature
Release Note