Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce config file for cainjector options #6345

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

inteon
Copy link
Member

@inteon inteon commented Sep 13, 2023

Similar to #5337, but for the cainjector.
The approach and structure is identical to the existing setup for the controller and for the webhook.

Kind

/kind feature

Release Note

CAInjector config can now be loaded from a config file.

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/api Indicates a PR directly modifies the 'pkg/apis' directory labels Sep 13, 2023
@inteon inteon force-pushed the config_cainjector branch 5 times, most recently from a8e924f to 9784cd5 Compare September 14, 2023 11:02
@jetstack-bot jetstack-bot added the area/deploy Indicates a PR modifies deployment configuration label Sep 20, 2023
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

This is so big that it's kinda hard to review. Part of that is our pattern of using k8s resources to define config rather than a much simpler format - that feels a bit like using a sledgehammer on a nail, but obviously it's the pattern we've established already so it makes sense to use it again here.

This is too big for me to be really confident about it, but I don't think that should be a blocker for us if tests pass, and I like the tests in cmd/cainjector/app/cainjector_test.go !

Thanks!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023
@SgtCoDFish SgtCoDFish merged commit c56a2fb into cert-manager:master Oct 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants