Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support loading controller configuration from a versioned file #5337

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Support loading controller configuration from a versioned file #5337

merged 3 commits into from
Jul 31, 2023

Commits on Jul 27, 2023

  1. Add to ability to start controller with config file 

    Signed-off-by: Cody W. Eilar <ecody@vmware.com>
    @AcidLeroy
    AcidLeroy committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    1243fe2 View commit details
    Browse the repository at this point in the history

  2. Address the non-optional values in internal config 

    - This  commit changes the internal config to have fewer number of
  optional parameters.  It changes the types to match the ones that are
  already present in https://github.com/kubernetes/apimachinery/blob/master/pkg/apis/meta/v1/conversion.go
  so that custom converters do not have to be written for types "int"
  and "float32".

Signed-off-by: Cody W. Eilar <ecody@vmware.com>
    @AcidLeroy
    AcidLeroy committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    6212b63 View commit details
    Browse the repository at this point in the history

  3. Preserve internal types 

    - Needed to add custom conversion functions to handle conversions from
  public facing types to internal ones.

Signed-off-by: Cody W. Eilar <ecody@vmware.com>
    @AcidLeroy
    AcidLeroy committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    282a6d5 View commit details
    Browse the repository at this point in the history