Skip to content

Commit

Permalink
Update controller-tools and add to renovate
Browse files Browse the repository at this point in the history
- Remove go group because it wasn't working anyway

Signed-off-by: Brady Siegel <brsiegel@amazon.com>
  • Loading branch information
bmsiegel committed May 15, 2024
1 parent 8378601 commit 2d01f8b
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 18 deletions.
21 changes: 8 additions & 13 deletions .github/renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,12 @@
"groupName": "all non-major dependencies",
"groupSlug": "all-minor-patch"
},
{
"matchPackageNames": [
"golang",
"go"
],
"matchUpdateTypes": [
"minor",
"major"
],
"groupName": "golang",
"groupSlug": "golang-update"
},
{
"matchPackageNames": [
"k8s.io/client-go",
"k8s.io/api",
"k8s.io/apimachinery"
"k8s.io/apimachinery",
"kubernetes-sigs/controller-tools"
],
"matchUpdateTypes": [
"major"
Expand All @@ -54,6 +43,12 @@
"depNameTemplate": "cert-manager/cert-manager",
"datasourceTemplate": "github-releases"
},
{
"fileMatch": ["^Makefile$"],
"matchStrings": ["CONTROLLER_GEN_VERSION := (?<currentValue>.*?)\\n"],
"depNameTemplate": "kubernetes-sigs/controller-tools",
"datasourceTemplate": "github-releases"
},
{
"fileMatch": ["^.github/workflows/on-safe-to-test-label.yml$"],
"matchStrings": ["GOVERSION=go(?<currentValue>.*?)\\n"],
Expand Down
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ DOCKER_IMAGE_NAME ?= cert-manager/aws-privateca-issuer/controller

# Image URL to use all building/pushing image targets
IMG ?= ${DOCKER_REGISTRY}/${DOCKER_IMAGE_NAME}:${VERSION}
# Produce CRDs that work back to Kubernetes 1.11 (no version conversion)
CRD_OPTIONS ?= "crd:trivialVersions=true,preserveUnknownFields=false"
# Produce CRDs that work back to Kubernetes 1.13 (no version conversion)
CRD_OPTIONS ?= "crd"

# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
ifeq (,$(shell go env GOBIN))
Expand All @@ -51,7 +51,7 @@ K8S_CLUSTER_NAME := pca-external-issuer
CERT_MANAGER_VERSION ?= v1.14.5

# Controller tools
CONTROLLER_GEN_VERSION := 0.5.0
CONTROLLER_GEN_VERSION := 0.15.0
CONTROLLER_GEN := ${BIN}/controller-gen-${CONTROLLER_GEN_VERSION}

# Helm tools
Expand Down Expand Up @@ -153,7 +153,7 @@ docker-push:

CONTROLLER_GEN = $(shell pwd)/bin/controller-gen
controller-gen:
$(call go-install-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.4.1)
$(call go-install-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v$(CONTROLLER_GEN_VERSION))

HELM_TOOL = $(shell pwd)/bin/helm-tool
helm-tool:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ Before running ```make cluster``` we will need to do the following:
* [Golang v1.17+](https://golang.org/)
* [Docker v17.03+](https://docs.docker.com/install/)
* [Kind v0.9.0+](https://kind.sigs.k8s.io/docs/user/quick-start/) -> This will be installed via running the test
* [Kubectl v1.11.3+](https://kubernetes.io/docs/tasks/tools/install-kubectl/)
* [Kubectl v1.13+](https://kubernetes.io/docs/tasks/tools/install-kubectl/)
* [AWS CLI v2](https://docs.aws.amazon.com/cli/latest/userguide/cli-chap-install.html)
* [Helm](https://helm.sh/docs/intro/install/)
* [Make](https://www.gnu.org/software/make/) Need to have version 3.82+
Expand Down

0 comments on commit 2d01f8b

Please sign in to comment.