Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Access Denied Exception in basic_ack Method #1777

Merged
merged 1 commit into from Sep 3, 2023

Conversation

flolas
Copy link
Contributor

@flolas flolas commented Aug 18, 2023

This change enhances the error handling within the system by specifically addressing the situation where access to an AWS queue is denied.

fixes: #1768

@auvipy auvipy self-requested a review August 19, 2023 13:52
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please rebase it?

@flolas
Copy link
Contributor Author

flolas commented Sep 1, 2023

@auvipy done

@auvipy auvipy added this to the 5.3.x milestone Sep 1, 2023
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we got a lint error remaining. can you check and fix it please?

@flolas
Copy link
Contributor Author

flolas commented Sep 1, 2023

@auvipy lint test ok

@auvipy auvipy merged commit c18e962 into celery:main Sep 3, 2023
14 checks passed
@flolas flolas deleted the fix/ISSUE-1768 branch September 6, 2023 15:51
@flolas flolas restored the fix/ISSUE-1768 branch September 6, 2023 15:51
@flolas flolas deleted the fix/ISSUE-1768 branch September 6, 2023 15:51
@flolas flolas restored the fix/ISSUE-1768 branch September 6, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQS Transport basic_ack does not handle common http errors (ie: AccessDeniedException / 400 http errors)
2 participants