Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update redis.txt to 4.3.6 to fix severe issue #1676

Merged
merged 3 commits into from Apr 19, 2023
Merged

Update redis.txt to 4.3.6 to fix severe issue #1676

merged 3 commits into from Apr 19, 2023

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Mar 28, 2023

No description provided.

@auvipy
Copy link
Member Author

auvipy commented Mar 28, 2023

should be updated based on redis/redis-py#2665

@auvipy
Copy link
Member Author

auvipy commented Mar 28, 2023 

          assert connparams['health_check_interval'] == 25

E KeyError: 'health_check_interval'

t/unit/transport/test_redis.py:867: KeyError

chayim
chayim reviewed Mar 29, 2023
View reviewed changes
requirements/extras/redis.txt Outdated
@@ -1 +1 @@
redis>=4.2.2,<4.4.0
redis>=4.3.6,<4.6.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you now want 4.3.7. GitHub pipelines seem plugged - but it should get there as soon as things wake up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but I haven't seen any release for that yet https://github.com/redis/redis-py/releases

@auvipy
Copy link
Member Author

auvipy commented Mar 29, 2023

also we need some suggestion to fix the failing test while upgrading from 4.3 to 4.4.x+

          assert connparams['health_check_interval'] == 25

E KeyError: 'health_check_interval'

t/unit/transport/test_redis.py:867: KeyError

auvipy
auvipy commented Apr 18, 2023
View reviewed changes
requirements/extras/redis.txt Outdated Show resolved Hide resolved
@auvipy auvipy marked this pull request as ready for review April 18, 2023 05:02
@auvipy auvipy added this to the 5.3 milestone Apr 18, 2023
@auvipy auvipy merged commit 3e098dc into main Apr 19, 2023
20 of 23 checks passed
@auvipy auvipy deleted the red branch April 19, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayim chayim chayim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@auvipy @chayim