Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support redis 5.x #8504

Merged
merged 1 commit into from
Sep 14, 2023
Merged

support redis 5.x #8504

merged 1 commit into from
Sep 14, 2023

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Sep 14, 2023

Description

support redis-py 5.x, as there is no breaking change except dropping Python 3.7 support, https://github.com/redis/redis-py/releases/tag/v5.0.0

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (add91ec) 87.44% compared to head (72dc66f) 87.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8504   +/-   ##
=======================================
  Coverage   87.44%   87.44%           
=======================================
  Files         148      148           
  Lines       18491    18491           
  Branches     3156     3156           
=======================================
  Hits        16169    16169           
  Misses       2033     2033           
  Partials      289      289           
Flag Coverage Δ
unittests 87.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to ensure it works with kombu well ffirst

@auvipy
Copy link
Member

auvipy commented Sep 14, 2023

depends on celery/kombu#1790

@auvipy auvipy added this to the 5.3.x milestone Sep 14, 2023
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is also passing in kombu so approving

@auvipy auvipy merged commit 3b20010 into celery:main Sep 14, 2023
30 checks passed
@dulmandakh dulmandakh deleted the patch-1 branch September 14, 2023 11:12
@dulmandakh
Copy link
Contributor Author

@auvipy could you please release a new version with the change.

@auvipy
Copy link
Member

auvipy commented Sep 14, 2023

Not before sept 30

@Nusnus
Copy link
Member

Nusnus commented Sep 14, 2023

Not before sept 30

@auvipy if you don't have any objections I can take care of that over the weekend.

Redis 5 can be a nice upgrade indeed!

P.S
Also relevant for Kombu

@Nusnus
Copy link
Member

Nusnus commented Sep 14, 2023

Not before sept 30

@auvipy if you don't have any objections I can take care of that over the weekend.

Redis 5 can be a nice upgrade indeed!

P.S
Also relevant for Kombu

We can also finish the new patch release policy and try it out already to see if it works as expected, I'm eager to get it done so I can find time to handle the release soon if you're ok with that bro @auvipy

@auvipy
Copy link
Member

auvipy commented Sep 14, 2023

let us first complete the release process template then we could go for it

@auvipy
Copy link
Member

auvipy commented Sep 14, 2023

also we might need to revert another PR. Let me handle the next release first, but if i can't manage enough time, I will ping you to do so instead of me

@Nusnus
Copy link
Member

Nusnus commented Sep 14, 2023

@auvipy

let us first complete the release process template then we could go for it

See new updates on the PR.

also we might need to revert another PR. Let me handle the next release first, but if i can't manage enough time, I will ping you to do so instead of me

Sure np!
Take notes as you follow the new checklist so we can have detailed feedback and know what works/comfortable and what still requires refining. Your experience would be very valuable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants