Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️πŸͺ update pre-commit hooks #282

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.284 β†’ v0.0.285](astral-sh/ruff-pre-commit@v0.0.284...v0.0.285)
- [github.com/asottile/blacken-docs: 1.15.0 β†’ 1.16.0](adamchainz/blacken-docs@1.15.0...1.16.0)
- [github.com/pre-commit/mirrors-prettier: v3.0.1 β†’ v3.0.2](pre-commit/mirrors-prettier@v3.0.1...v3.0.2)
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Aug 21, 2023
@burgholzer
Copy link
Member

@hillmich could you take a look at the docs failure here? It does not seem to be related to the changes here.
Probably has to do with the newer Sphinx updates to version 7 (that broke quite some things around the Python ecosystem).

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #282 (53dcdac) into main (9237103) will increase coverage by 0.2%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main    #282     +/-   ##
=======================================
+ Coverage   94.9%   95.1%   +0.2%     
=======================================
  Files         20      20             
  Lines       1951    1951             
  Branches     348     348             
=======================================
+ Hits        1853    1857      +4     
+ Misses        98      94      -4     

see 2 files with indirect coverage changes

@hillmich
Copy link
Member

You are right, it's the Sphinx version (or rather the breathe extension).

breathe-doc/breathe#943

I added a requirement to have Sphinx <7 until the breathe issue is fixed.

@burgholzer
Copy link
Member

You are right, it's the Sphinx version (or rather the breathe extension).

breathe-doc/breathe#943

I added a requirement to have Sphinx <7 until the breathe issue is fixed.

Alright. Thanks for checking! We just need to keep track of that issue then and remove the upper cap as soon as possible.

@hillmich hillmich merged commit 4416a6f into main Aug 22, 2023
21 checks passed
@hillmich hillmich deleted the pre-commit-ci-update-config branch August 22, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants