Add basename and fix extension value for fog file

[leductienttkt]

About this PR

Make basename and extension of CarrierWave::SanitizedFile and CarrierWave::Storage::Fog::File the same

My code

• carrierwave.rb

CarrierWave.configure do |config|
  case Rails.env
  when 'test', 'development'
    config.storage :file
    ...

  when 'production', 'staging'
    config.storage :fog
    ...
  end
end

• models/document.rb

class Document < ApplicationRecord
  mount_uploader :file, DocumentFileUploader
  ...
end

• What I want to show in view:
  document.file.file.extension
document.file.file.basename

It works fine in development environment, but I have problem in production.
After checking, I got the result as below.
I think we shouldn't return different values in different environments for the same function.

Actual results

when file has complicated extensions , ex: complex.filename.tar.gz

• config.storage :file

• config.storage :fog

when file has simple extension, ex: simple.extension

• config.storage :fog

when file has no extension, ex: filename

• config.storage :file

• config.storage :fog

Expected results

when file has complicated extensions , ex: complex.filename.tar.gz

• basename: complex.filename
• extension: tar.gz

when file has simple extension, ex: simple.extension

• basename: simple
• extension: extension

when file has no extension, ex: filename

• basename: filename
• extension: ""

[mshibuya]

Can this logic extracted into a separate module like CarrierWave::Utilities::Filename and shared with CarrierWave::SanitizedFile 's, instead of just copying the implementation?

[leductien-rightsvn]

@mshibuya
Thanks for review.
I fixed it！

[mshibuya]

Awesome, thanks!