Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aria-label to Range example #5472

Merged

Conversation

JuanFernandoCastaneda
Copy link
Contributor

@JuanFernandoCastaneda JuanFernandoCastaneda commented Feb 12, 2025

Done

Added an aria-label to the inputs in Range example for accessibility purposes.

Fixes #5416

QA

  • Check /docs/examples/base/forms/range

Not sure if I should update the package.json version

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Screenshots

Before
image

After
image

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
minrk Min RK
@webteam-app
Copy link

JuanFernandoCastaneda is not a collaborator of the repo

@jmuzina jmuzina added Review: QA needed Review: Code +1 Documentation 📝 Documentation changes or updates Accessibility Review: Percy needed This PR needs a review of Percy for visual regressions Review: Percy +1 Review: QA +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions Review: QA needed labels Feb 12, 2025
Copy link
Member

@jmuzina jmuzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the a11y contribution @JuanFernandoCastaneda ! No version bump is needed as you are not changing any component SCSS /scss or higher-order-component macros (/templates/_macros), so this is good as-is.

@jmuzina jmuzina merged commit 4db1dd5 into canonical:main Feb 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range input examples are missing accessible labels
3 participants