[DPE-3247] Add creation of non-existing namespace #96
Conversation
| logger.warn( | ||
| f"Namespace {namespace} does not exist, and it could not be created." | ||
| ) | ||
| raise NamespaceNotFound(namespace) |
There was a problem hiding this comment.
nit: In my opinion this class name doesn't truly describe that the namespace could not be created (which is the case because Exception catches everything that is thrown during the creation of namespace).
| logger.warn( | ||
| f"Namespace {namespace} does not exist, and it could not be created." | ||
| ) | ||
| raise NamespaceNotFound(namespace) |
There was a problem hiding this comment.
Also I believe we haven't caught NamespaceNotFound yet in main. Therefore, the raise here will possibly pass through the except Exception block in main from where it will be raised again.
There was a problem hiding this comment.
On this regard, it'd be awesome if we could add an integration test for this scenario (where the SA that is creating the namespace doesn't have enough permissions). However I'm not sure if there's a way to do that without involving pods and all complexities.
There was a problem hiding this comment.
I agree with the point raised by @theoctober19th . It would be good to have the restricted permission tests, to make sure we have proper error handling
This PR adds the capability of the spark8t lib to create the namespace if it does not exist.