Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove organize and place in INSTALL directly #187

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Remove organize and place in INSTALL directly #187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e136b20
Remove organize and place in INSTALL directly
Jul 4, 2023
ca1d1b9
new line
Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 10 additions & 5 deletions snap/snapcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ parts:
build-packages:
- bzr
- gcc
- git
build-snaps:
- go
prime:
Expand All @@ -40,20 +41,24 @@ parts:
www-static:
plugin: dump
source: ./static
organize:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand the reason for the change, looking at the reference here https://snapcraft.io/docs/snapcraft-yaml-reference it says that for organise

the key represents the path of a file inside the part and the value represents how the file is going to be staged.

Shouldn't the static folder be present when building the snap?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading your message on CS Private again, this is because we can't organize a folder I guess?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah pretty much, that's why it was broken, so when I moved it manually, all good

static: www/static/
source-type: local
override-build: |
mkdir -p $SNAPCRAFT_PART_INSTALL/www/static
mv ./* $SNAPCRAFT_PART_INSTALL/www/static

www-templates:
plugin: dump
source: ./templates
organize:
templates: www/templates/

source-type: local
override-build: |
mkdir -p $SNAPCRAFT_PART_INSTALL/www/templates
mv ./* $SNAPCRAFT_PART_INSTALL/www/templates

# Dump scripts required to configure candidsrv
scripts:
plugin: dump
source: ./snap/local/scripts
source-type: local
organize:
# Place wrapper in bin such that it can be called easily
wrapper.sh: bin/
Expand Down