Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove organize and place in INSTALL directly #187

Merged
merged 2 commits into from Jul 5, 2023

Conversation

ale8k
Copy link
Contributor

@ale8k ale8k commented Jul 4, 2023

Description

Fixes the candid snap.

There were two issues:

  1. Git wasn't present
  2. You cannot organise directories, so instead we manually move the assets into install.

Run the following to test:

snapcraft
snap install ./*.snap --dangerous
sudo snap set candid candid.storage.type=memory 
sudo snap set candid candid.private-key=q2G3A2NjTe7MP9D8iugCH9XfBAyrnV8n8u8ACbNyNOY=
sudo snap set candid candid.public-key=OAG9EVDFgXzWQKIk+MTxpLVO1Mp1Ws/pIkzhxv5Jk1M=
sudo snap logs candid

Picture of candid started:
image

@@ -40,20 +41,24 @@ parts:
www-static:
plugin: dump
source: ./static
organize:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand the reason for the change, looking at the reference here https://snapcraft.io/docs/snapcraft-yaml-reference it says that for organise

the key represents the path of a file inside the part and the value represents how the file is going to be staged.

Shouldn't the static folder be present when building the snap?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading your message on CS Private again, this is because we can't organize a folder I guess?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah pretty much, that's why it was broken, so when I moved it manually, all good

@ale8k ale8k merged commit b3c4436 into canonical:master Jul 5, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants