Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix urllib3 mocking to conform to current API #602

Merged
merged 7 commits into from
May 29, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions requirements.docs.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
Sphinx==2.4.4
docutils==0.16
jinja2<3.1 # We need an older version due to compatilibility
markupsafe<2.1 # Needed because of jinja2
Sphinx==7.0.1
25 changes: 21 additions & 4 deletions tests/test_requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import requests
import responses
import socket
import sys
import threading
import time
from urllib.parse import urlunsplit
Expand Down Expand Up @@ -482,15 +483,30 @@ def set_responses(self, responses):

def make_response(self, content, status='200 OK', headers={}):
"""Make a fake http.client.HTTPResponse based on a byte stream."""
wgrant marked this conversation as resolved.
Show resolved Hide resolved
if not headers:
headers["Content-Type"] = "text/html"

formatted_headers = '\r\n'.join(
'{}: {}'.format(k, v) for k, v in headers.items()
)
stream = 'HTTP/1.1 {}\r\n{}\r\n{}'.format(
stream = 'HTTP/1.1 {}\r\n{}\r\n\r\n{}'.format(
status, formatted_headers, content,
)
sock = FakeSocket(stream.encode('utf8'))
response = http.client.HTTPResponse(sock)
response.begin() # parse the stream
http_response = http.client.HTTPResponse(sock)
http_response.begin()

# Python versions below 3.7 expect a non-urllib3 response.
if sys.version_info.minor < 7:
wgrant marked this conversation as resolved.
Show resolved Hide resolved
return http_response

response = urllib3.response.HTTPResponse(
body=http_response,
headers=headers,
status=http_response.status,
preload_content=False,
original_response=http_response,
)
return response

def make_request(self, pool, conn, method, url, **kwargs):
Expand Down Expand Up @@ -688,7 +704,8 @@ def test_adapter_exceptions_match_default(mock_urllib3, retry, response):

exc = None
try:
session.get('http://default/')
response = session.get('http://default/')
response.raise_for_status()
except Exception as e:
exc = e

Expand Down