Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add the ability for to ouput to the YDWG-02 #50

Merged
merged 14 commits into from
Apr 4, 2019
Merged

feature: add the ability for to ouput to the YDWG-02 #50

merged 14 commits into from
Apr 4, 2019

Conversation

jncarter123
Copy link
Contributor

The YDWG-02 uses a raw format described in http://www.yachtd.com/downloads/ydwg02.pdf

The format of messages sent from application to Device is the same, but without time
and direction field. Outgoing messages must end with . If the message
from application is accepted, passes filters and is transmitted to NMEA 2000,
it will be sent back to the application with ‘T’ direction.
For example, the application sends the following sentence to the Device:
19F51323 01 02
When this message is sent to the NMEA 2000 network, the Application receives
an answer like:
17:33:21.108 T 19F51323 01 02

Closes #49

@sbender9
Copy link
Member

You need to support nmea2000JsonOut too. Most of the signalk-to-nmea2000 stuff uses it.

@jncarter123
Copy link
Contributor Author

Thank you Scott, I've added the support for nmea2000JsonOut.

@jncarter123
Copy link
Contributor Author

Scott,
It looks like the tests are failing for the YDWG due to the input time being set to 16:29:27.082 while the expected time is set to 21:29:27.082. Should I update these to match?

@sbender9
Copy link
Member

Yes, you can change those timestamps

@jncarter123
Copy link
Contributor Author

Thank you Scott for the comments. I've fixed each of those now.

@sbender9
Copy link
Member

sbender9 commented Apr 3, 2019

Thanks! Will test tomorrow. I have one in my lab now to test with. (They were awesome enough to send me a free unit!)

@sbender9
Copy link
Member

sbender9 commented Apr 3, 2019

Getting:

Apr  3 15:01:03 homepi signalk-server[4648]: ReferenceError: toYDWGRawFormat is not defined
Apr  3 15:01:03 homepi signalk-server[4648]:     at pgnToYdwgRawFormat (/usr/lib/node_modules/signalk-server/node_modules/@canboat/canboatjs/lib/toPgn.js:304:3)
Apr  3 15:01:03 homepi signalk-server[4648]:     at Ydwg02Stream.sendPGN (/usr/lib/node_modules/signalk-server/node_modules/@canboat/canboatjs/lib/ydwg02.js:80:15)
Apr  3 15:01:03 homepi signalk-server[4648]:     at Object.Ydwg02Stream.options.app.on (/usr/lib/node_modules/signalk-server/node_modules/@canboat/canboatjs/lib/ydwg02.js:60:12)
Apr  3 15:01:03 homepi signalk-server[4648]:     at emitOne (events.js:116:13)
Apr  3 15:01:03 homepi signalk-server[4648]:     at Object.emit (events.js:211:7)

@sbender9 sbender9 changed the title feature: added the ability for to ouput to the YDWG-02 feature: add the ability for to ouput to the YDWG-02 Apr 4, 2019
@sbender9 sbender9 merged commit ff0fba4 into canboat:master Apr 4, 2019
@jncarter123 jncarter123 deleted the YDWG-n2kout branch April 4, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants