fix: build stream processor with SimpleMeterRegistry #1228
Merged
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicpuppa
force-pushed
the
fix-stream-processor
branch
from
fb4c867 to
9a5dcd8
Compare
I already raised this in this thread. This PR fix only one issue with the tests @mustafadagher |
|
@nicpuppa given this fixes the setup issue and the failure is an existing other issue, I would suggest to merge it to not have to include two different fixes into one PR. So once this is merged we can focus on the timer test fix separately, wdyt? Can we skip the queue for that? |
I think we can disable the queue from the settings, let me check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide to stream processor a simple meter registry