Don't handle log storage append errors #1168
Merged
+7
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We typically build ZPT against the latest Zeebe changes. This is automatically adjusted on release.
The log storage in Zeebe no longer deals with errors explicitly. So, ZPT also doesn't have to. See: camunda/camunda@07da250
|
bors merge |
ghost
pushed a commit
that referenced
this pull request
Apr 29, 2024
1168: Don't handle log storage append errors r=korthout a=korthout ## Description <!-- Please explain the changes you made here. --> This PR helps resolve a compile error in ZPT when building against Zeebe 8.6.0-SNAPSHOT. To do so, it: - bumps the zeebe version to `8.6.0-SNAPSHOT` (this is automatically adjusted by the release) - removes the error handling in the InMemoryLogStorage's append method (this is no longer necessary) ## Related issues <!-- Which issues are closed by this PR or are related --> closes #1166 <!-- Cut-off marker _All lines under and including the cut-off marker will be removed from the merge commit message_ ## Definition of Ready Please check the items that apply, before requesting a review. You can find more details about these items in our wiki page about [Pull Requests and Code Reviews](https://github.com/camunda/zeebe/wiki/Pull-Requests-and-Code-Reviews). * [ ] I've reviewed my own code * [ ] I've written a clear changelist description * [ ] I've narrowly scoped my changes * [ ] I've separated structural from behavioural changes --> ## Definition of Done <!-- Please check the items that apply, before merging or (if possible) before requesting a review. --> _Not all items need to be done depending on the issue and the pull request._ Code changes: * [x] The changes are backwards compatibility with previous versions * [ ] If it fixes a bug then PRs are created to backport the fix Testing: * [ ] There are unit/integration tests that verify all acceptance criterias of the issue * [ ] New tests are written to ensure backwards compatibility with further versions * [ ] The behavior is tested manually Documentation: * [ ] Javadoc has been written * [ ] The documentation is updated Co-authored-by: Nico Korthout <nico.korthout@camunda.com>
|
Build failed: |
|
bors retry |
ghost
pushed a commit
that referenced
this pull request
Apr 29, 2024
1168: Don't handle log storage append errors r=korthout a=korthout ## Description <!-- Please explain the changes you made here. --> This PR helps resolve a compile error in ZPT when building against Zeebe 8.6.0-SNAPSHOT. To do so, it: - bumps the zeebe version to `8.6.0-SNAPSHOT` (this is automatically adjusted by the release) - removes the error handling in the InMemoryLogStorage's append method (this is no longer necessary) ## Related issues <!-- Which issues are closed by this PR or are related --> closes #1166 <!-- Cut-off marker _All lines under and including the cut-off marker will be removed from the merge commit message_ ## Definition of Ready Please check the items that apply, before requesting a review. You can find more details about these items in our wiki page about [Pull Requests and Code Reviews](https://github.com/camunda/zeebe/wiki/Pull-Requests-and-Code-Reviews). * [ ] I've reviewed my own code * [ ] I've written a clear changelist description * [ ] I've narrowly scoped my changes * [ ] I've separated structural from behavioural changes --> ## Definition of Done <!-- Please check the items that apply, before merging or (if possible) before requesting a review. --> _Not all items need to be done depending on the issue and the pull request._ Code changes: * [x] The changes are backwards compatibility with previous versions * [ ] If it fixes a bug then PRs are created to backport the fix Testing: * [ ] There are unit/integration tests that verify all acceptance criterias of the issue * [ ] New tests are written to ensure backwards compatibility with further versions * [ ] The behavior is tested manually Documentation: * [ ] Javadoc has been written * [ ] The documentation is updated Co-authored-by: Nico Korthout <nico.korthout@camunda.com>
|
Build failed: |
|
Seems to fail flaky on: However, I don't want to reopen it because the log files are missing. There's nothing that would help resolve that issue now. The last time it was closed after adding more logs. So I'm just gonna retry again. bors retry |
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR helps resolve a compile error in ZPT when building against Zeebe 8.6.0-SNAPSHOT.
To do so, it:
8.6.0-SNAPSHOT(this is automatically adjusted by the release)Related issues
closes #1166
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: