docs: Additions for review #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliotwrobson
changed the title
|
@eliotwrobson Is this ready for my review yet? I would ask that any work-in-progress PRs be kept in Draft state until they are ready for my final approval. |
|
@caleb531 not quite yet, this PR is in the unique situation where we're really waiting on approval by the reviewers that opened the original issue. They may ask for more changes, so makes sense to leave as a draft for now 👍 |
30 tasks
caleb531
reviewed
Jun 4, 2024
caleb531
reviewed
Jun 4, 2024
caleb531
reviewed
Jun 4, 2024
Co-authored-by: Caleb Evans <caleb@calebevans.me>
Co-authored-by: Caleb Evans <caleb@calebevans.me>
caleb531
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress performance documentation examples for #213. Will write second example shortly.
EDIT: Added second example. @phildong these should be ready to try locally!
EDIT 2: Added note for issues with graphviz installation #223, an example for NFA instantiation #220, and the first part of #221 @irisdyoung
Corresponding review: pyOpenSci/software-submission#152