Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example request #221

Closed
irisdyoung opened this issue May 16, 2024 · 2 comments
Closed

Example request #221

irisdyoung opened this issue May 16, 2024 · 2 comments

Comments

@irisdyoung
Copy link

In the provided examples at https://caleb531.github.io/automata/examples/fa-examples/ it would be helpful if we could get

  • all the necessary context to reproduce the examples (e.g. definitions for the nfa1 and nfa2 referenced under "Subset for NFAs")
  • expected outputs to compare against

Personally I would prefer encapsulation in example scripts structured so that we can import and reuse those objects. Sticking the entire first example code block in a file will produce a valid script that only does one thing, whereas wrapping the input loop in a function definition would allow my_dfa to be imported into the next example. Similarly, making a words_within(edit_distance) function or something similar would give the new user something to play with a bit more interactively.

(These are suggestions to consider, not demands.)

@eliotwrobson
Copy link
Collaborator

I think adding some encapsulation and making the examples a little more narrative driven is a good move 👍🏽

@eliotwrobson
Copy link
Collaborator

eliotwrobson commented Jun 4, 2024

Examples in documentation have been updated on the develop branch, closing.

Link to review: pyOpenSci/software-submission#152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants