Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare some missing dynamic properties in tests #229

Merged

Conversation

jamisonbryant
Copy link
Contributor

Adds the required trait to suppress deprecation warnings related to dynamic props in the plugin test suite.

I figured the trait was the best solution since these are just test cases, however if it would be better for me to just declare the props explicitly (& well-typed) I'm happy to do that instead.

@ADmad
Copy link
Member

ADmad commented Jan 10, 2023

It would be better to declare the properties used instead.

@LordSimal
Copy link
Contributor

Make sure to run composer cs-fix to auto-fix CS problems.
But in the end composer cs-check should all be green before you commit.

@jamisonbryant jamisonbryant changed the title Add AllowDynamic trait to suppress deprecation warning Declare some missing dynamic properties in tests Jan 10, 2023
@markstory markstory added this to the 2.1.x milestone Jan 12, 2023
@markstory markstory merged commit dc470f4 into cakephp:2.x Jan 12, 2023
@markstory
Copy link
Member

Thank you 🎉

@jamisonbryant jamisonbryant deleted the bugfix/add-php8-dynamic-props-trait branch November 3, 2023 14:10
@jamisonbryant jamisonbryant restored the bugfix/add-php8-dynamic-props-trait branch November 3, 2023 14:10
@jamisonbryant jamisonbryant deleted the bugfix/add-php8-dynamic-props-trait branch November 3, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants