Update verbalizer error message to include the relevant template string #414
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mynhardt Burger <mynhardt@gmail.com>
mynhardtburger
requested review from
gkumbhat,
evaline-ju and
gabe-l-hart
as code owners
gkumbhat
reviewed
Feb 28, 2025
gkumbhat
reviewed
Feb 28, 2025
| ) | ||
| return source_object[index_object] | ||
|
|
||
| if not hasattr(source_object, index_object): | ||
| error( | ||
| "<NLP97715112E>", | ||
| AttributeError( | ||
| "Requested template string is not a valid property of type" | ||
| "Requested template string '%s' is not a valid property of type", | ||
| index_object, |
There was a problem hiding this comment.
also we should check if this index_object is actually a string, otherwise might cause problem without explicit stringification
There was a problem hiding this comment.
I don't think it is possible for the fstring to fail no matter the type of index_object, unless the __str__ dunder method was overwritten and that raises an exception.
By default str() is used to serialize the object. At worst the the output might be in repr() format.
Co-authored-by: Gaurav Kumbhat <kumbhat.gaurav@gmail.com> Signed-off-by: Mynhardt Burger <mynhardt@gmail.com>
Co-authored-by: Gaurav Kumbhat <kumbhat.gaurav@gmail.com> Signed-off-by: Mynhardt Burger <mynhardt@gmail.com>
Signed-off-by: Mynhardt Burger <mynhardt@gmail.com>
Signed-off-by: Mynhardt Burger <mynhardt@gmail.com>
Signed-off-by: Mynhardt Burger <mynhardt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the exception message to include the template field which is the cause for the error.