Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リソース詳細情報へのデータ挿入方法の変更 #169

Merged
merged 4 commits into from
May 16, 2024

Conversation

keita-yasuda
Copy link
Contributor

@keita-yasuda keita-yasuda commented May 14, 2024

他の外部プラグインとのテンプレートファイルの競合を考慮して、リソース情報を格納する変数へ直接代入する方法に修正。

※データセット詳細情報へのデータ挿入は別PRで対応

@keita-yasuda keita-yasuda marked this pull request as ready for review May 16, 2024 04:09
ckanext/feedback/plugin.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 99.80%. Comparing base (7f556ac) to head (e02b379).
Report is 117 commits behind head on main.

Files Patch % Lines
ckanext/feedback/plugin.py 70.58% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #169      +/-   ##
===========================================
- Coverage   100.00%   99.80%   -0.20%     
===========================================
  Files           31       32       +1     
  Lines         2430     2547     +117     
  Branches        86      150      +64     
===========================================
+ Hits          2430     2542     +112     
- Misses           0        1       +1     
- Partials         0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryo-ma ryo-ma merged commit eabbaa3 into main May 16, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants