組織名が特定可能な場合にテンプレートで取得できるようにする #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keita-yasuda
changed the title
keita-yasuda
commented
May 9, 2024
| @@ -48,6 +48,24 @@ def search(): | |||
| id, keyword, approval, admin_owner_orgs, org_name | |||
There was a problem hiding this comment.
NOTE: GETのクエリに含まれる id は Resource.id 又は Package.id である事が想定されている。
Sheile
reviewed
May 9, 2024
Sheile
reviewed
May 9, 2024
Sheile
reviewed
May 9, 2024
| # set it as a global variable accessible from templates. | ||
| if id and not org_name: | ||
| resource = registration_service.get_resource(id) | ||
| package: model.Package |
There was a problem hiding this comment.
型定義のためかもしれませんが、代入もせずにぽつんと変数名だけがあるのはなかなか違和感のある記述ですね。
どこか参考にしたコードなどありますでしょうか？
There was a problem hiding this comment.
参考にしたコードはありません。
コードの文脈を意識して読みやすくするための記述のつもりでしたが、違和感をご指摘いただいたので削除いたします。
Sheile
approved these changes
May 14, 2024
ryo-ma
approved these changes
May 15, 2024
ryo-ma
reviewed
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
以下のテンプレート内で
{% c.pkg_dict['organization']['name'] %}にて組織名を取得できるように修正。※ 組織名取得元DBカラム：ckan.model.group.name