Build and deploy ARM-based containers #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuft2
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
LGTM , maybe add a note in the README about the computer architecture and Oracle since I'm not sure everyone is downloading the binaries. The Classes API has the binaries copied for example.
Nvm, this is just the hello world template, so they should download the right binaries if they're going to use oracle instant client.
|
Correct. Check out the linked issue for more details. 🙂 |
Terraform Plan:will create 1 resource:
will update 2 resources:
will replace (delete then create) 1 resource:
|
|
@stuft2 - We should document this, but I'm not sure where that belongs in the README. |
|
Once actions/runner-images#5631 is resolved, we may be able to remove the QEMU step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on byu-oit/terraform-aws-fargate-api#38, which I'm assuming will be released as
v5.0.0.Closes #389