Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt: eliminate race test errors #545

Merged
merged 4 commits into from
Nov 7, 2023
Merged

opt: eliminate race test errors #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8254f72
feat: nocheckptr for `rt.IndexChar`
AsterDY Oct 26, 2023
f9b7398
add more race flag
AsterDY Oct 26, 2023
c30f6b6
Merge branch 'main' into opt/race
AsterDY Oct 31, 2023
974beb5
Merge branch 'main' into opt/race
AsterDY Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/compatibility_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ jobs:
${{ runner.os }}-go-

- name: main
run: GOMAXPROCS=4 go test -v -race github.com/bytedance/sonic
run: GOMAXPROCS=4 go test -v -gcflags="all=-l" -race github.com/bytedance/sonic

- name: ast
run: GOMAXPROCS=4 go test -v -race github.com/bytedance/sonic/ast
run: GOMAXPROCS=4 go test -v -gcflags="all=-l" -race github.com/bytedance/sonic/ast

- name: qemu
run: sh scripts/qemu.sh
3 changes: 2 additions & 1 deletion internal/rt/fastmem.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,16 @@ func FuncAddr(f interface{}) unsafe.Pointer {
}
}

//go:nocheckptr
func IndexChar(src string, index int) unsafe.Pointer {
return unsafe.Pointer(uintptr((*GoString)(unsafe.Pointer(&src)).Ptr) + uintptr(index))
}

//go:nocheckptr
func IndexByte(ptr []byte, index int) unsafe.Pointer {
return unsafe.Pointer(uintptr((*GoSlice)(unsafe.Pointer(&ptr)).Ptr) + uintptr(index))
}

//go:nosplit
func GuardSlice(buf *[]byte, n int) {
c := cap(*buf)
l := len(*buf)
Expand Down