fix: (decoder) return io.EOF when read nothing from io.Reader

bytedance · Jul 1, 2022 · f59f42c · f59f42c
1 parent fc6f374
commit f59f42c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/decoder/stream.go b/decoder/stream.go
@@ -80,6 +80,9 @@ read_more:
         if err != nil {
             repeat = false
             if err == io.EOF {
+                if n == 0 {
+                    return err
+                }
                 break
             }
             self.err = err

diff --git a/decoder/stream_test.go b/decoder/stream_test.go
@@ -35,6 +35,20 @@ var (
     strings.Repeat("2",1024)+`"} b {}`
 )
 
+func TestDecodeEmpty(t *testing.T) {
+    var str = ``
+    var r1 = strings.NewReader(str)
+    var v1 interface{}
+    var d1 = json.NewDecoder(r1)
+    var r2 = strings.NewReader(str)
+    var v2 interface{}
+    var d2 = NewStreamDecoder(r2)
+    es1 := d1.Decode(&v1)
+    ee1 := d2.Decode(&v2)
+    assert.Equal(t, es1, ee1)
+    assert.Equal(t, v1, v2)
+}
+
 func TestDecodeSingle(t *testing.T) {
     var str = _Single_JSON