Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update syn requirement from 1.0 to 2.0 #157

Merged
merged 1 commit into from Apr 8, 2023

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Apr 5, 2023

Superseeds #156

Some parts taken from tokio-rs/tokio#5572

@ihciah
Copy link
Member

ihciah commented Apr 6, 2023

Hi~ Thanks for your contribution, could you fix the clippy warning in CI?

@pickfire
Copy link
Contributor Author

pickfire commented Apr 6, 2023

Sorry, just have the time to do it, I believe it's fixed now.

@ihciah
Copy link
Member

ihciah commented Apr 7, 2023

There seems to be something wrong with the latest version of clippy. It suggest using Vec<MaybeUninit<T>> when with_capacity() and then set_init() in docs, but infact it gives warning.
Could you please help ignore it like adding #[allow(clippy::uninit_vec)] or some other ways?

@pickfire
Copy link
Contributor Author

pickfire commented Apr 8, 2023

I believe this should be fixed in rust-lang/rust-clippy#10565, should we wait? I guess not since even with the latest clippy we still have this issue. I ping them in the pull request.

@ihciah ihciah merged commit 461e747 into bytedance:master Apr 8, 2023
4 of 5 checks passed
@pickfire pickfire deleted the bump-syn branch April 11, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants