Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cranelift: Split out dominator tree's depth-first traversal into a reusable iterator #8640

Merged
merged 1 commit into from
May 20, 2024

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented May 16, 2024

We intend to use this when computing liveness of GC references in cranelift-frontend to manually construct safepoints and ultimately remove r{32,64} reference types from CLIF, cranelift-codegen, and regalloc2.

@fitzgen fitzgen requested review from a team as code owners May 16, 2024 22:18
@fitzgen fitzgen requested review from cfallin and removed request for a team May 16, 2024 22:18
…usable iterator

We intend to use this when computing liveness of GC references in
`cranelift-frontend` to manually construct safepoints and ultimately remove
`r{32,64}` reference types from CLIF, `cranelift-codegen`, and `regalloc2`.

Co-Authored-By: Trevor Elliott <telliott@fastly.com>
@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label May 17, 2024
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice generalization -- LGTM!

@fitzgen fitzgen added this pull request to the merge queue May 20, 2024
Merged via the queue into bytecodealliance:main with commit cacfaf8 May 20, 2024
35 checks passed
@fitzgen fitzgen deleted the reusable-dfs-iterator branch May 20, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants