Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a panic calling host functions with refs in async mode #8434

Merged
merged 1 commit into from
Apr 22, 2024

Commits on Apr 22, 2024

  1. Fix a panic calling host functions with refs in async mode

    This commit fixes a panic when a host function defined with `Func::new`
    returned GC references and was called in async mode. The logic to
    auto-gc before the return values go to wasm asserted that a synchronous
    GC was possible but the context this function is called in could be
    either async or sync. The fix applied in this commit is to remove the
    auto-gc. This means that hosts will need to explicitly GC in these
    situations until auto-gc is re-added back to Wasmtime.
    
    cc bytecodealliance#8433 as this will make the behavior consistent, but we'll want to
    re-add the gc behavior.
    alexcrichton committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    6c9630d View commit details
    Browse the repository at this point in the history