Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift/x64: Rely on zero-extended constants #8299

Merged
merged 1 commit into from
Apr 4, 2024

Commits on Apr 4, 2024

  1. cranelift/x64: Rely on zero-extended constants

    Since bytecodealliance#6850, we've been able to rely on `iconst` instructions having
    their immediate operands' high bits zeroed before lowering.
    
    So a couple of places in `x64/lower.rs` can be expressed more simply now
    as a result.
    
    Out of an abundance of caution, I added a debug-assertion when constants
    are looked up during lowering, to check that earlier phases really did
    ensure the high bits are zero.
    
    I also got rid of an `expect` where a simple pattern-match will do.
    jameysharp committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    363ebfb View commit details
    Browse the repository at this point in the history