cranelift/x64: Rely on zero-extended constants #8299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cranelift
Since bytecodealliance#6850, we've been able to rely on `iconst` instructions having their immediate operands' high bits zeroed before lowering. So a couple of places in `x64/lower.rs` can be expressed more simply now as a result. Out of an abundance of caution, I added a debug-assertion when constants are looked up during lowering, to check that earlier phases really did ensure the high bits are zero. I also got rid of an `expect` where a simple pattern-match will do.
jameysharp
force-pushed
the
x64-lower-consts
branch
from
ffbc410
to
363ebfb
Compare
|
Turns out I can't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #6850, we've been able to rely on
iconstinstructions having their immediate operands' high bits zeroed before lowering.So a couple of places in
x64/lower.rscan be expressed more simply now as a result.Out of an abundance of caution, I added a debug-assertion when constants are looked up during lowering, to check that earlier phases really did ensure the high bits are zero.
I also got rid of an
expectwhere a simple pattern-match will do.