Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[inline] to forwarding methods of wasmparser::collections types #1566

Merged
merged 4 commits into from
May 20, 2024

Conversation

Robbepop
Copy link
Contributor

@Robbepop Robbepop commented May 19, 2024

I applied #[inline] to all trivial methods of types in the wasmparser::collections submodule as stated here.

I ran benchmarks on main and the PR and built main and PR after a cargo clean to observe the performance impact of the changes on both compilation and execution. The tl;dr is that compile times are the same, and I only see minor improvements on execution.

Build times:

  • main: 16.08s user 0.46s system 343% cpu 4.822 total
  • PR: 16.04s user 0.46s system 348% cpu 4.736 total

Benchmarks: (PR run after main run)

Default Features

image

Features: no-hash-maps

image

@alexcrichton alexcrichton added this pull request to the merge queue May 20, 2024
Merged via the queue into bytecodealliance:main with commit 006fe63 May 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants