Add #[inline]
to forwarding methods of wasmparser::collections
types
#1566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I applied
#[inline]
to all trivial methods of types in thewasmparser::collections
submodule as stated here.I ran benchmarks on
main
and the PR and builtmain
and PR after acargo clean
to observe the performance impact of the changes on both compilation and execution. The tl;dr is that compile times are the same, and I only see minor improvements on execution.Build times:
main
: 16.08s user 0.46s system 343% cpu 4.822 totalBenchmarks: (PR run after
main
run)Default Features
Features:
no-hash-maps