Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public deps from wasm-metadata's API #1130

Merged
merged 1 commit into from Jul 17, 2023

Commits on Jul 17, 2023

  1. Remove public deps from wasm-metadata's API

    Currently whenever `wasmparser` or `wasm-encoder` have a major version
    bump this requires a major revision of `wasm-metadata` to be released
    due to their appearance in the API of `wasm-metadata`. This in turn
    forces a major version bump of `wit-component` due to `wit-component`'s
    usage of `wasm-metadata` in its public API.
    
    The `wasmparser` and `wasm-encoder` crates, however, are relatively
    "unstable" crates in that the amount of features they support for wasm
    are shifting quite a lot over time meaning that they have a lot of major
    version bumps. Coupling this rate of change to `wit-component` which is
    expected to be embedded in many WIT-related bindings generators I'm
    predicting won't be the best development story.
    
    To decouple these crates this commit removes the `wasmparser` and
    `wasm-encoder` types from the API of `wasm-metadata` by making them
    internal implementation details. After this it's possible to have a
    major revision of `wasmparser` without updating the major revision of
    `wasm-metadata` or `wit-component` for example.
    alexcrichton committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    0d7b96e View commit details
    Browse the repository at this point in the history