Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix p{read,write}v{,v2}'s encoding of the offset argument on Linux. #896

Merged
merged 1 commit into from Oct 25, 2023
Merged

Fix p{read,write}v{,v2}'s encoding of the offset argument on Linux. #896

merged 1 commit into from Oct 25, 2023

Commits on Oct 25, 2023

  1. Fix p{read,write}v{,v2}'s encoding of the offset argument on Linux. 

    Unlike with `p{read,write}`, Linux's `p{read,write}v` syscall's offset
argument is not passed in an endian-specific order. And, the expectation is
for syscall wrappers to always pass both the high and low halves of the
offset as separate arguments, even though on 64-bit architectures the low
half is passed throgh as a 64-bit value containing the full offset and the
kernel doesn't mask it.

And `p{read,write}v2` follow the behavior of `p{read,write}`.
    @sunfishcode
    sunfishcode committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b600b01 View commit details
    Browse the repository at this point in the history