Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GNU/Hurd support #844

Merged
merged 1 commit into from Sep 25, 2023
Merged

Add GNU/Hurd support #844

merged 1 commit into from Sep 25, 2023

Conversation

sthibaul
Copy link
Contributor

No description provided.

@sunfishcode
Copy link
Member

Thanks! This looks good; could you also add a cargo check -Z build-std --target=i686-unknown-hurd-gnu --features=all-apis line to the "Check selected Tier 3 platforms" section in .github/workflows/main.yml script, so that we avoid breaking GNU/Hurd support in the future?

@sthibaul
Copy link
Contributor Author

Yes, that'll just have to wait for rust-lang/libc#3325 to land

@sunfishcode
Copy link
Member

Ah, I didn't realize we were at that early stage of the process. My sense then is that we can merge this now, and add the CI check later once it's ready.

@sunfishcode sunfishcode merged commit d3158ed into bytecodealliance:main Sep 25, 2023
43 checks passed
@sthibaul sthibaul mentioned this pull request Sep 26, 2023
Merged
@sthibaul
Copy link
Contributor Author

Thanks, I have created the backport PR #852 for rustc bootstrap

@sunfishcode
Copy link
Member

This is now released in rustix 0.38.15.

@sthibaul
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sthibaul @sunfishcode