Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix renameat_with with flags on Android. #892

Merged
merged 1 commit into from Oct 23, 2023
Merged

Fix renameat_with with flags on Android. #892

merged 1 commit into from Oct 23, 2023

Conversation

sunfishcode
Copy link
Member

When renameat_with is passed non-zero flags, fall back to the syscall! macro on ABIs such as Android where libc has a renameat but not a renameat2.

Fixes Stebalien/tempfile#259.

@sunfishcode
Fix renameat_with with flags on Android.
194290c 
When `renameat_with` is passed non-zero flags, fall back to the
`syscall!` macro on ABIs such as Android where libc has a `renameat` but
not a `renameat2`.

Fixes Stebalien/tempfile#259.
@sunfishcode sunfishcode mentioned this pull request Oct 23, 2023
Closed
@sunfishcode sunfishcode merged commit e2314b7 into main Oct 23, 2023
43 checks passed
@sunfishcode sunfishcode deleted the sunfishcode/android-renameat2 branch October 23, 2023 23:51
@sunfishcode
Copy link
Member Author

This is now released in rustix 0.38.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NamedTempFile::persist_noclobber panicks on Android
1 participant
@sunfishcode