Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NamedTempFile::persist_noclobber panicks on Android #259

Closed
neonphog opened this issue Oct 16, 2023 · 4 comments · Fixed by bytecodealliance/rustix#892 or #261
Closed

NamedTempFile::persist_noclobber panicks on Android #259

neonphog opened this issue Oct 16, 2023 · 4 comments · Fixed by bytecodealliance/rustix#892 or #261

Comments

@neonphog
Copy link

Due to this assertion in rustix: https://github.com/bytecodealliance/rustix/blob/v0.38.3/src/backend/libc/fs/syscalls.rs#L511
@Stebalien
Copy link
Owner

cc @sunfishcode

sunfishcode added a commit to bytecodealliance/rustix that referenced this issue Oct 23, 2023
@sunfishcode
Fix renameat_with with flags on Android.
194290c 
When `renameat_with` is passed non-zero flags, fall back to the
`syscall!` macro on ABIs such as Android where libc has a `renameat` but
not a `renameat2`.

Fixes Stebalien/tempfile#259.
@sunfishcode sunfishcode mentioned this issue Oct 23, 2023
Merged
@sunfishcode
Copy link
Contributor

Thanks for the report! I've now submitted bytecodealliance/rustix#892 with a fix.

@neonphog neonphog mentioned this issue Oct 23, 2023
Merged
sunfishcode added a commit to bytecodealliance/rustix that referenced this issue Oct 23, 2023
@sunfishcode
Fix renameat_with with flags on Android. (#892)
e2314b7 
When `renameat_with` is passed non-zero flags, fall back to the
`syscall!` macro on ABIs such as Android where libc has a `renameat` but
not a `renameat2`.

Fixes Stebalien/tempfile#259.
@sunfishcode
Copy link
Contributor

The rustix bug here is now fixed in rustix 0.38.21.

@neonphog neonphog mentioned this issue Oct 26, 2023
Merged
@neonphog
Copy link
Author

Woot - android CI is now passing sans-workaround. Thanks @sunfishcode 🙌 - closing this.

Stebalien added a commit that referenced this issue Oct 26, 2023
@Stebalien
chore: update rustix to 0.38.21
003d8f3 
fixes #259
This was referenced Oct 26, 2023
Merged
Open
Stebalien added a commit that referenced this issue Oct 26, 2023
@Stebalien
chore: update rustix to 0.38.21 (#261)
f3854da 
fixes #259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Stebalien @neonphog @sunfishcode